[bitnami/suitecrm] fix: SKIP_BOOTSTRAP not working properly with suitecrm 8 #82432
Conversation
javsalgar
changed the title
|
Hi! Thank you so much for the PR! Could you fix the DCO issue? |
* Create .env.local file to support new SuiteCRM 8 config, as well as added necessary properties and updates to the legacy config.phpo * .htacces file at public/legacy/.htaccess was included, which blocked necessary resources. Signed-off-by: David Márquez Fàbrega <[email protected]>
|
This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution. |
|
Due to the lack of activity in the last 5 days since it was marked as "stale", we proceed to close this Pull Request. Do not hesitate to reopen it later if necessary. |
bitnami-bot
added
stale
|
I did fix what was asked i think. What happened? |
javsalgar
added
in-progress
verify
|
This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution. |
|
. |
|
Thanks a lot for your contribution. Just a quick note to apologize for the slower response time in reviewing PRs. August is a holiday period for part of the team, so reviews may take a bit longer than usual. We really appreciate your patience and support! |
|
Sorry, i didn't want that to come across as rude, I do not expect these things to be addressed in a timely matter, in the end its Open source, so it's just natural. I just think that if that's the case then this automatic closing of pull requests gives the impression that contributions are just forgotten :) |
migruiz4
left a comment
migruiz4
left a comment
There was a problem hiding this comment.
Thank you very much for your contribution @DavidMarquezF!
I'm sorry for the late response, could you please take a look at my comments?
bitnami/suitecrm/8/debian-12/rootfs/opt/bitnami/scripts/libsuitecrm.sh
Outdated
Show resolved
Hide resolved
bitnami/suitecrm/8/debian-12/rootfs/opt/bitnami/scripts/libsuitecrm.sh
Outdated
Show resolved
Hide resolved
bitnami/suitecrm/8/debian-12/rootfs/opt/bitnami/scripts/libsuitecrm.sh
Outdated
Show resolved
Hide resolved
bitnami/suitecrm/8/debian-12/rootfs/opt/bitnami/scripts/libsuitecrm.sh
Outdated
Show resolved
Hide resolved
bitnami/suitecrm/8/debian-12/rootfs/opt/bitnami/scripts/libsuitecrm.sh
Outdated
Show resolved
Hide resolved
bitnami/suitecrm/8/debian-12/rootfs/opt/bitnami/scripts/suitecrm/postunpack.sh
Show resolved
Hide resolved
|
This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution. |
|
Due to the lack of activity in the last 5 days since it was marked as "stale", we proceed to close this Pull Request. Do not hesitate to reopen it later if necessary. |
bitnami-bot
added
stale
|
Hey, sorry, a lot of work came in and I couldn't spend the time on reviewing your requests. I prepped a commit in order to follow the review observations. If you open the pull request again, ill submit them in |
Signed-off-by: David Márquez Fàbrega <[email protected]>
This is necessary when running SuiteCRM with ACA for instance. The host name is the ACA hostname but the real hostname needs to be enabled here in order to not get blocked for XSRF for some queries
5 participants
Description of the change
This is my go at making SuiteCRM 8 work properly with
SKIP_BOOSTRAPflag set to true, which currently doesn't work. I think when migrating from 7 to 8 this path was missed.This flag allows you to not have to keep the whole SuiteCRM installation in a persisted volume by initializing everything from scratch but the database.
The thing that still doesn't work which I haven't had a go at is the SMTP set up.
What I've solved:
This has been more of a surgical fix, but in general the code should/could be cleaned up a lot to remove all the SuiteCRM 7 related code since it's not officially supported anymore by bitnami
Benefits
SKIP_BOOTSTRAPflag functional again.Possible drawbacks
public/legacy/.htaccesswas included in the first place, but it was also something that did not work properly when running SuiteCRM 7, as it blocks resoruces like images and icons behind 403. Please let me know if this is maybe introducing any security holesApplicable issues
Additional information