Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes UI issues #5883

Merged
merged 3 commits into from
Jan 21, 2025
Merged

Fixes UI issues #5883

merged 3 commits into from
Jan 21, 2025

Conversation

cakesoft-vaibhav
Copy link
Collaborator

@cakesoft-vaibhav cakesoft-vaibhav commented Jan 20, 2025 •
edited
Loading

  1. Fixes seed signer setup modal, missing icons.
  2. Updates concierge details modal ui. Technical Support: UI change #5848
  3. Sign transaction medium selection modal ui. Sign transaction via QR: UI issue. #5877

IMG_6233

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
14.3% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@cakesoft-vaibhav cakesoft-vaibhav marked this pull request as ready for review January 20, 2025 08:49
ben-kaufman
ben-kaufman reviewed Jan 21, 2025
View reviewed changes
src/screens/KeeperConcierge/CreateTicket.tsx
};

const handleModelSelectAll = () => {
console.log({ allKeysTrue });
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should remove log

@ben-kaufman ben-kaufman merged commit 9016500 into sprint Jan 21, 2025
2 of 3 checks passed
@ben-kaufman ben-kaufman deleted the feat/conciergeDetails branch January 21, 2025 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ben-kaufman ben-kaufman ben-kaufman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cakesoft-vaibhav @ben-kaufman