Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set or update read-only flag when address books are renamed #1124

Merged
merged 6 commits into from
Nov 7, 2024
Merged

Set or update read-only flag when address books are renamed #1124

merged 6 commits into from
Nov 7, 2024

Conversation

sunkup
Copy link
Member

@sunkup sunkup commented Nov 6, 2024 •
edited
Loading

Purpose

Currently, when address books are updated, readOnly is only updated when forceReadOnly != null. However readOnly should always be calculated and the nowReadOnly != readOnly block executed, if applicable.

Short description

  • always calculate read only
  • extract read only calculation to companion method and reuse

Checklist

  • The PR has a proper title, description and label.
  • I have self-reviewed the PR.
  • I have added documentation to complex functions and functions that can be used by other modules.
  • I have added reasonable tests or consciously decided to not add tests.

@sunkup sunkup linked an issue Nov 6, 2024 that may be closed by this pull request
LocalAddressBook: set/update readOnly when address books are renamed #1114
Closed
@sunkup sunkup self-assigned this Nov 6, 2024
@sunkup sunkup added the bug Something isn't working label Nov 6, 2024
@sunkup sunkup requested a review from rfc2822 November 6, 2024 14:25
@sunkup sunkup marked this pull request as ready for review November 6, 2024 14:26
@sunkup sunkup removed the request for review from rfc2822 November 7, 2024 09:40
@sunkup sunkup marked this pull request as draft November 7, 2024 09:40
@sunkup sunkup force-pushed the 1114-localaddressbook-setupdate-readonly-when-address-books-are-renamed branch from a44df88 to c202d92 Compare November 7, 2024 09:43
@sunkup sunkup marked this pull request as ready for review November 7, 2024 09:50
@sunkup sunkup requested a review from rfc2822 November 7, 2024 09:51
@sunkup sunkup changed the title 1114 localaddressbook setupdate readonly when address books are renamed Set or update readonly flag when address books are renamed Nov 7, 2024
@rfc2822 rfc2822 changed the title Set or update readonly flag when address books are renamed Set or update read-only flag when address books are renamed Nov 7, 2024
@rfc2822 rfc2822 merged commit 32925dc into main-ose Nov 7, 2024
8 checks passed
@rfc2822 rfc2822 deleted the 1114-localaddressbook-setupdate-readonly-when-address-books-are-renamed branch November 7, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfc2822 rfc2822 rfc2822 approved these changes

Assignees

@sunkup sunkup

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LocalAddressBook: set/update readOnly when address books are renamed
2 participants
@sunkup @rfc2822