Replace android sync framework result class with our own #1094
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
More control over the sync result and less dependency on android.
Short description
SyncResult
data class with the following differences:databaseError
withlocalStorageError
andcontentProviderError
; Updated it's usages.SyncStats
data class with the following differences:Note
I have not added
SyncResult
toBaseSyncWorker
even though it's the only place where it's used, bacauseBaseSyncWorker
is a damn long file already.I have not added tests yet because I am afraid there will be wishes for changes in the design.
Further Information
https://developer.android.com/reference/android/content/SyncResult
Checklist