Fix incompatibility with Postgres 14.x #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Postgres v14.0 to v14.5 had an issue with functions taking a `RECORD` typed argument when within a single transaction this type was instantiated with different actual types (tables). In combination with my refactorings in Carbonite v0.12.0, extracting two smaller procs from the main change tracking procedure. This patch reverts these refactorings and restores compatibility with the affected Postgres versions. Refactorings weren't exactly pretty, either. But the issues with the 150 line procedure I keep copying over to new versions remain. Fixes #112
maltoe
force-pushed
the
issue/112-pg-14-broken
branch
from
63bec17
to
e940e2a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Postgres v14.0 to v14.5 had an issue with functions taking a
RECORDtyped argument when within a single transaction this type was instantiated with different actual types (tables). In combination with my refactorings in Carbonite v0.12.0, extracting two smaller procs from the main change tracking procedure.This patch reverts these refactorings and restores compatibility with the affected Postgres versions. Refactorings weren't exactly pretty, either. But the issues with the 150 line procedure I keep copying over to new versions remain.
Fixes #112