Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#762] Inputs #767

Open
wants to merge 21 commits into
base: main
Choose a base branch
from
Open

[#762] Inputs #767

wants to merge 21 commits into from

Conversation

planktonic
Copy link
Member

@planktonic planktonic commented Apr 13, 2023 •
edited
Loading

Fixes #762

Changes

  • Structuring the button custom properties to make variants work better, and to be more usable in situations like joined-ui
  • turning off prettier in more files, as it makes the Sass unreadable
  • Updated text input styles
  • stories for inputs, selects, labels, and textareas are in separate js files, and all within forms
  • Adds components for inputs, selects, labels, and textareas
  • checkboxes & radios now can have box-shadows in each state
  • adds an invalid state for radios & checkboxes

📸 Looks like

Screenshot 2023-08-15 at 16 04 15

How to QA

👀 Visual changes

  • git fetch
  • git checkout feature/762-inputs
  • yarn
  • yarn storybook
  • navigate to base/forms

Check:

  • The appearance matches the design in Zeplin
  • The Zeplin component is correctly linked in storybook
  • The documentation for this component is correct, understandable, and up-to-date.

👾 Code changes

Check:

  • The documentation for this component is correct, understandable, and up-to-date.
  • The component makes good use of CSS custom properties to simplify creating variants (or doesn’t have variants).
  • Everything that should be a variable, is.

Preflight checks

  • Storybook documentation has been updated
  • Fixtures in test/scss/ have been updated
  • Your changes have been added to the unreleased section of CHANGELOG.md

@planktonic planktonic force-pushed the feature/762-inputs branch 2 times, most recently from 5cebeb0 to b19e591 Compare May 4, 2023 09:41
@planktonic planktonic changed the base branch from main to feature/759-update-button-joined-component May 17, 2023 08:13
@planktonic planktonic force-pushed the feature/762-inputs branch from 290ddcd to 0b5923a Compare May 17, 2023 15:18
@planktonic planktonic force-pushed the feature/759-update-button-joined-component branch from 4e49543 to c370f9c Compare May 22, 2023 08:06
Base automatically changed from feature/759-update-button-joined-component to main May 22, 2023 08:14
@planktonic planktonic force-pushed the feature/762-inputs branch from 0b5923a to 65ea179 Compare May 22, 2023 08:28
@planktonic planktonic marked this pull request as ready for review August 15, 2023 14:17
@planktonic
[#762] Inputs
9fead7e 
#762
@planktonic
- Structuring the button custom properties to make variants work bett…
b90c34b 
…er, and to be more usable in situations like joined-ui

- turning off prettier in more files, as it makes the Sass unreadable
@planktonic
- Text input styles
2c791d1 
- stories and a component for inputs
@planktonic
- Adds a label component
c91d351 
- updates radio & checkbox stories
@planktonic
- Moves all the components & associated low-level stories to the `for…
2df4cd6 
…ms` folder

- Documentation is now all in `Base/Forms`, where the examples are of real usage instead of for testing purposes
@planktonic
- Select component now has options
67a6e19 
- checkboxes & radios now can have box-shadows in each state
- adds an invalid state for radios & checkboxes
@planktonic
WIP form stories
6c4ccc3
@planktonic
WIP
eca6b5d 
- added select styles
- adding radio & checkbox styles
- Text inputs no lopnger wrapped with labels

TODO:
- apply the focus styles from feature/757-update-link-component
- apply the shadows from feature/749-update-badge-components
- update stories
- add all the extra checked/unchecked versions of states
@planktonic
- Updates stories to cover all states
8a2f1b8 
- Adds sass variables for the extra states on checkboxes & radios
- All stories now include labels
@planktonic
- Corrects colors
a62f1b2 
- Cleanup stories
- Adds zeplinLinks where available
- Adds descriptive children/labels
@planktonic
- Adds focus styles for all the inputs
d927e05 
- linting
@planktonic
- Buttons now have the correct line-height & font-size
883bf80 
- Selects 7 inputs subtract their border from their height in order to match the designs
- Input-texts inside an `o-joined-ui` now work properly (border-radiuses etc)
@planktonic
- Selects, inputs, and buttons all now play well together in joined-ui
b56db0f 
- Moves some storties out of ui/forms.mdx, into a js file
@planktonic
Update fixtures
a143666
@planktonic
WIP updating fixtures after rebase
04a9af3
@planktonic
Correct invalid states
adad5bc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Redesign
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inputs
1 participant
@planktonic