Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bandwidth congestion and rate from radio driver #479

Closed
wants to merge 3 commits into from

Conversation

knmcguire
Copy link
Member

@knmcguire knmcguire commented Sep 26, 2024

Just an example of how the congestion of the bandwidth can be calculated per null packet, along with the rate of the up and down link.

Not sure if this should actually be a call back of the crazyflie instance itself, since it is a statistic that is more linked to the crazyradio hardware as it looks at all the packets send. But the original link_quality was implemented like this though.

This is connected to #469

@gemenerik
Copy link
Member

If I understand correctly we need to count these packets at this low level, so the current implementation with a callback makes sense to me. Just a heads-up that counting null packets could be affected if we decide to "ease up" on them, as we discussed.

This is just a draft PR but some more implementation thoughts: If we’re using a callback, we might consider merging the low-level and existing quality callbacks into a single object with all the relevant information. I think the existing quality callback is passed to other links, but just not used, so we could do that here, too. Also, let’s consider moving all link statistics out of the run method into their own method (including the ack/retry quality stat).

@knmcguire
Copy link
Member Author

This is currently blocked until we are sure of the structure of #477

@gemenerik gemenerik changed the base branch from master to rik/uplink_rssi October 3, 2024 11:09
@gemenerik gemenerik changed the base branch from rik/uplink_rssi to master October 3, 2024 11:09
@gemenerik
Copy link
Member

Continued in #480

@gemenerik gemenerik closed this Oct 3, 2024
@knmcguire
Copy link
Member Author

Thanks! I'll remove the branch as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants