Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added deepgram for transcription #97

Merged
merged 10 commits into from
May 15, 2023

Conversation

masterchief164
Copy link
Contributor

This PR fixes #96.

Copy link
Member

@adamjonas adamjonas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In testing it out, whisper is much more accurate than the default nova model. I'd suggest leaving the current whisper code as is and adding a flag to use deepgram but be able to pass it various models.

One of the problems is that the chapters breaking up the timestamps. Instead of breaking up the file, I'd suggest adding the headers by locating the timestamp and keeping the file intact. That might be difficult without granular timestamps like deepgram provides, but it should be possible even with the whisper srt format. If we keep the file intact, we also should get summarization via deepgram which can close #38.

Additionally, the default should be with the speaker diarization off and turn it on via flag and/or adding multiple speakers to the speakers metadata.

app/application.py Show resolved Hide resolved
@masterchief164
Copy link
Contributor Author

One of the problems is that the chapters breaking up the timestamps. Instead of breaking up the file, I'd suggest adding the headers by locating the timestamp and keeping the file intact. That might be difficult without granular timestamps like deepgram provides, but it should be possible even with the whisper srt format. If we keep the file intact, we also should get summarization via deepgram which can close #38.

Could you please provide an example of the first part.

@adamjonas
Copy link
Member

@adamjonas
Copy link
Member

adamjonas commented May 12, 2023

testing the chapters

tstbtc '1Z7GjXgdUy4' test-dir -p -D -C produces https://github.com/adamjonas/bitcointranscripts/pull/146/files and https://github.com/adamjonas/bitcointranscripts/pull/145/files, which both cut off before transcribing the last chapter of the video.

Otherwise this is ready to merge.

EDIT: 025e519 should fix it

@masterchief164
Copy link
Contributor Author

This PR also fixes #38

@masterchief164 masterchief164 requested a review from adamjonas May 12, 2023 10:51
@adamjonas adamjonas merged commit f0d9d9c into bitcointranscripts:main May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: use deepgram for transcription
2 participants