fix: Transcript Page feedback #70
Conversation
|
@0tuedon is attempting to deploy a commit to the btc-knowledge-base Team on Vercel. A member of the Team first needs to authorize it. |
0tuedon
force-pushed
the
fixes-individual-transcript
branch
from
266ae54 to
71fbae7
Compare
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
0tuedon
changed the title
0tuedon
force-pushed
the
fixes-individual-transcript
branch
from
71fbae7 to
2e2d329
Compare
| const topicsWithTitles = topics.map(topic => { | ||
| const currentTopic = allTopics.find( topicData => topicData.slug === topic ); | ||
| return currentTopic; | ||
| } ) | ||
|
|
There was a problem hiding this comment.
Can we handle this at the Contentlayer level? Specifically, replacing topic slugs with their full names during the Contentlayer processing step. This would eliminate the need to perform the replacement every time we display topic tags, such as on the source page, where this replacement is currently not accounted for:
There was a problem hiding this comment.
@0tuedon any update on this?
is the suggestion clear?
There was a problem hiding this comment.
Can we handle this at the Contentlayer level? Specifically, replacing topic slugs with their full names during the Contentlayer processing step. This would eliminate the need to perform the replacement every time we display topic tags, such as on the source page, where this replacement is currently not accounted for
But if we replace the topic slugs with their names then we need to to createSlug everytime we want a link?
There was a problem hiding this comment.
mmm, true.
For clarity, to get the topic name do we unsluggify or we have a lookup with the actual name?
cc: @kouloumos @0tuedon
what of using an object in contentLayer for tags, something like {name: "P2P", slug: "p2p"}
or as a new computedField
There was a problem hiding this comment.
Currently what I did, which @kouloumos pointed out is to find the topics by looping through allTopics and get the name for them. This only fixes it one place at a time.
To Test,
Link
This PR also closes #71