-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(contentlayer): Improve Topics Processing and Generation #61
fix(contentlayer): Improve Topics Processing and Generation #61
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
63ec26b
to
c0d8a1c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work on the pr and addition of our own topic index. That said, I've been able to test the pr both the latest deployment and the code and I think everything works accordingly. I left a comment on what I think might be a value add but everything works as is.
52c8937
to
6bbe171
Compare
- fix issues with generation of topics - streamline the code by grouping the calculations and generation into a single method - more meaningful names for json outputs
c0d8a1c
to
6a848a2
Compare
6a848a2
to
7e38e17
Compare
Rebased and made a minor change based on @IgboPharaoh comment. |
A couple of comments I made elsewhere, providing them here for context: the tags on bitcointranscripts do not always correlate to the topics in https://github.com/bitcoinsearch/topics-index/blob/main/topics.json For example, this transcript These tags aren't topics in the topics.json from the topic index, neither are they any topic aliases. Therefore they won't be accounted for in @kouloumos what is the consensus whether the changes will be on bitcoin-transcript or we add them to the respective alias in topics index? Also this change directly maps to how we select topics in transcripts queuer (switch to utilizing topic index rather than optech tags) |
In the That said, I just added a configuration in the topics-index that allows for custom category slugs that solves this issue. So we should be good to go! To give additional context on your questions:
What you are describing is not how we currently use the The issue arises from the fact that those specific tags/slugs don't follow the pattern that we have with the rest of the misc category tags.
good point! We will need to change that also. It will be a simple change, just switching the source of truth JSON. I don't really like the way that we are currently selecting those topics inside the Editor, as we are only using the slugs, with no additional context to help the reviewer decide/understand the tag. We have that information (through the |
…ology - terminology change to refer to "topics" instead of "categories" - Simplify data processing to do a single pass and use a single structure - Consolidate JSON generation into cleaner functions
- start using our own topics index instead of optech's - add different display option for misc topics in categories
7e38e17
to
b03cd26
Compare
They aren't under miscellaneous anymore in the latest deployment. This PR looks good to go apart from that |
They were at the time of your comment. Then I pushed a change (which I am explaining in the same comment) to deal with the issue that you raised. So now, you can see a "Miscellaneous" topic under the "P2P Network Protocol" and "Lightning Network" categories, following the same pattern as the rest of the categories. |
okay got it |
This PR fixes #54 and and introduces improvements to the structure and handling of topic data in the content layer.
Key Changes
/categories
and/topics
pages.tag-data.json
→topics-by-category-counts.json
topics-data.json
→topics-counts.json