Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: source data structure to account for languages and metadata #57

Merged
merged 2 commits into from
Nov 18, 2024

Conversation

IgboPharaoh
Copy link
Collaborator

@IgboPharaoh IgboPharaoh commented Nov 12, 2024

This PR:

  • Refactors the setup algorithm
  • Adds transcript count to level 2 sources
  • Updates breadcrumb to use titles

fixes #53
closes #45
closes #41

Copy link

vercel bot commented Nov 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
registry ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 13, 2024 8:12am

@Emmanuel-Develops
Copy link
Collaborator

Emmanuel-Develops commented Nov 13, 2024

Nice work!

Missing breadcrumb

Noticing that the transcript card does not have the grey breadcrumbs above the title anymore. Was this intentional?
Screenshot 2024-11-13 at 2 27 38 PMScreenshot 2024-11-13 at 2 25 46 PM

left: this PR ; right: current prod

what do you guys think about skipping the breadcrumb on the card?
cc: @kouloumos @aassoiants

language on sources

That aside. I love this
Screenshot 2024-11-13 at 2 23 32 PM

Following up on yesterday's discussion, we should also have languages on root source page i.e https://btctranscripts.com/es/sources. This isn't much priority right now given that backlinks on sources and transcripts have been catered for.
Documentend in #59 (this should be a separate PR, as some changes to content-layer in this PR will unblock #52)
cc: @IgboPharaoh

@Emmanuel-Develops Emmanuel-Develops changed the title refactor setup algorithm Refactor: source data structure to account for languages and metadata Nov 13, 2024
@IgboPharaoh
Copy link
Collaborator Author

Noticing that the transcript card does not have the grey breadcrumbs above the title anymore. Was this intentional?

Yes this was intentional. Why I removed this was because it was as if we were rendering similar data in 3 different places.
The breadcrumb above, the page title and the breadcrumb in the card

Following up on yesterday's discussion, we should also have languages on root source page

I think we should account for this in a different PR

@Emmanuel-Develops Emmanuel-Develops merged commit 8e7db61 into staging Nov 18, 2024
2 checks passed
Emmanuel-Develops pushed a commit that referenced this pull request Nov 29, 2024
…#57)

* refactor setup algorithm

* chore: remove slug from transcript card
Emmanuel-Develops added a commit that referenced this pull request Nov 29, 2024
* Refactor: source data structure to account for languages and metadata (#57)

* Add boss banner (#63)

* chore: add source to transcript card (#60)

* Individual Transcript Page (#52)

Co-authored-by: 0tuedon <[email protected]>
Co-authored-by: IgboPharaoh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants