Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Suggest source for transcription #34

Open
wants to merge 1 commit into
base: staging
Choose a base branch
from

Conversation

kouloumos
Copy link
Member

@kouloumos kouloumos commented Sep 17, 2024

enables the related button and onSubmit calls
the intenal /suggestSource endpoint which
then calls the newly introduced /suggestSource
endpoint in the Review app which is then
responsible for all the related logic.

Demo
Screencast from 2024-09-17 16-08-27.webm

Notes for testing:
You have to define the REVIEW_APP_URL env variable to point to a deployment of the Review Platform that runs bitcointranscripts/transcription-review-front-end#300

Copy link

vercel bot commented Sep 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
registry ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 15, 2024 7:22am

@kouloumos
Copy link
Member Author

@IgboPharaoh please note that the modal is problematic on smaller screens

registry-suggest-modal-issue-ezgif com-video-to-gif-converter

@Emmanuel-Develops Emmanuel-Develops force-pushed the staging branch 2 times, most recently from 5d1e798 to 1f16071 Compare September 24, 2024 13:56
@Emmanuel-Develops Emmanuel-Develops force-pushed the staging branch 2 times, most recently from b1ab946 to 41d80e3 Compare October 14, 2024 20:23
enables the related button and onSubmit calls
the intenal `/suggestSource` endpoint which
then calls the newly introduced `/suggestSource`
endpoint in the Review app which is then
responsible for all the related logic.
@kouloumos
Copy link
Member Author

Rebased and tested!

@Emmanuel-Develops
Copy link
Collaborator

I couldn't suggest this transcript
Greg Heartsfield: The Nostr Protocol Explained

Screenshot 2024-10-29 at 11 26 57 AM

cc: @kouloumos

@kouloumos
Copy link
Member Author

I couldn't suggest this transcript

@Emmanuel-Develops did you try to suggest it through this PR's deployment? Cause you need the REVIEW_APP_URL env variable, which I guess that is not defined in the deployment?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants