Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Topic Name Display in /topics page #54

Open
kouloumos opened this issue Nov 5, 2024 · 0 comments
Open

Topic Name Display in /topics page #54

kouloumos opened this issue Nov 5, 2024 · 0 comments
Assignees

Comments

@kouloumos
Copy link
Member

There is an issue with the topics-data.json generation in our content layer algorithm. Currently, the topics-data.json file is not displaying the correct names for each topic on the /topics page. Unlike tag-data.json, which correctly uses the title field for each topic (as coming from BitcoinOps), topics-data.json appears to use a different approach, resulting in inconsistencies in topic names.

Current Structure:

  • tag-data.json: Groups topics into categories, showing the count of transcripts for each topic. Used for the /categories page.
  • topics-data.json: Lists all topics with the count of transcripts for each, used for the /topics page.

Proposed Solution:

  1. Consolidate JSON Generation: Since both JSON files represent similar data in different formats (by category and alphabetically), we can streamline the code by grouping the calculations and generation into a single method (still generating 2 different JSONs). This change will help avoid similar issues in the future.

  2. File Renaming: For clarity, rename the JSON files:

    • tag-data.jsontopics-by-category-counts.json
    • topics-data.jsontopics-counts.json

This change will make the file purposes clearer and reduce the chance of confusion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant