Add Error::SerdeJson variant and remove unwraps on submit_package#171
Merged
oleonardolima merged 4 commits intobitcoindevkit:masterfrom Feb 12, 2026
Merged
Conversation
luisschwab
changed the title
Error::SerdeJson variant and remove unwraps on submit_package'Error::SerdeJson variant and remove unwraps on submit_package
Member
Author
|
@oleonardolima we'll need to bump |
Pull Request Test Coverage Report for Build 21926755551Details
💛 - Coveralls |
luisschwab
force-pushed
the
feat/serde-json-err-variant
branch
from
f8e8492 to
ee70e95
Compare
luisschwab
force-pushed
the
feat/serde-json-err-variant
branch
from
ee70e95 to
e93c1b1
Compare
luisschwab
force-pushed
the
feat/serde-json-err-variant
branch
from
e93c1b1 to
d651e71
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #161.
Replaces #163.
This PR adds a new error variant for
serde_jsonand removes the lingering unwraps on thesubmit_packagemethods.Changelog Notice
Also bumps
electrsdto v0.36.1 and fixes MSRV dependency pinning.