chore(deps): update reqwest to 0.12#118
Merged
ValuedMammal merged 1 commit intobitcoindevkit:masterfrom Mar 17, 2025
Merged
Conversation
Pull Request Test Coverage Report for Build 13823581735Details
💛 - Coveralls |
7ce1e08 to
e624151
Compare
Contributor
Author
|
Update: |
e624151 to
2b0cd90
Compare
Contributor
Author
|
Finally buckled down and got everything building w/ 1.63 locally.
|
Contributor
|
@phlip9 Thanks for looking into it, I'll try to get things working on my end as well |
Contributor
Author
|
Ahh looks like some dev-dependencies also need to be pinned... |
2b0cd90 to
d84d8d0
Compare
Contributor
Author
|
Pinned |
chrono-raven6i90
added a commit
to chrono-raven6i90/rust-esplora-client
that referenced
this pull request
Oct 28, 2025
…west` to `0.12`
d84d8d04897d0ce1311d90b2f017df844a06a615 chore(deps): update `reqwest` to `0.12` (Philip Kannegaard Hayes)
Pull request description:
Updating to LDK 0.1, I noticed `esplora-client` is the last dep we have using `reqwest-v0.11`, which forces us to hold on to a ton of duplicate, old deps in our tree (http 0.2, hyper 0.14, rustls 0.21, ...). Updating `reqwest` to `0.12` removes all these for us.
I've also updated the 1.63.0 MSRV instructions to pin `reqwest-v0.12.9`, the last version with that MSRV. Later `reqwest` versions bump the MSRV to 1.64.0.
ACKs for top commit:
ValuedMammal:
ACK d84d8d04897d0ce1311d90b2f017df844a06a615
Tree-SHA512: 9fffb57e30f8efcc3f96fe5f0f8aa0cbada9dfc5285f49e4205f8668faae706534fce5f73d1de3e37496c4517f652ae508c59751796bdc101cecc1c12ba21626
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating to LDK 0.1, I noticed
esplora-clientis the last dep we have usingreqwest-v0.11, which forces us to hold on to a ton of duplicate, old deps in our tree (http 0.2, hyper 0.14, rustls 0.21, ...). Updatingreqwestto0.12removes all these for us.I've also updated the 1.63.0 MSRV instructions to pin
reqwest-v0.12.9, the last version with that MSRV. Laterreqwestversions bump the MSRV to 1.64.0.