Base58chk-encoded extended keys are always 111 characters long. Amend wording of BIP accordingly #727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… wording of BIP accordingly. -This results in a Base58-encoded string of up to 112 characters. +This results in a Base58-encoded string of exactly 111 characters. Version bytes: 0x0488b21e (“xpub”), 0x0488ade4 (“xprv”), 0x043587cf (“tpub”), 0x04358394 (“tprv”) Largest “possible” key: kL = 0x0488b21effffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff (78 bytes) b58chk(kL) = xpubEPi3iGSX9RiyuXPTijevUmMctBDQs2TWCMgUd3qKp6qCgUc8RUsPdPBrRC6whFeWTg37DcmnJJiKFL73DH4sjdApJkXBD3vFcBP4xHq3fPY (111 chars) Smallest “possible” key: kS = 0x043583940000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000 (78 bytes) b58chk(kS) = tprv8ZgxMBicQKsPcsbCVeqqF1KVdH7gwDJbxbzpCxDUsoXHdb6SnTPYxdwSAKDC6KKJzv7khnNWRAJQsRA8BBQyiSfYnRt6zuu4vZQGKjeW4YF (111 chars)
Add Trust to compatible wallets
fix bip-0016 link 404
ghost
approved these changes
Oct 18, 2018
… wording of BIP accordingly. -This results in a Base58-encoded string of up to 112 characters. +This results in a Base58-encoded string of exactly 111 characters. Version bytes: 0x0488b21e (“xpub”), 0x0488ade4 (“xprv”), 0x043587cf (“tpub”), 0x04358394 (“tprv”) Largest “possible” key: kL = 0x0488b21effffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff (78 bytes) b58chk(kL) = xpubEPi3iGSX9RiyuXPTijevUmMctBDQs2TWCMgUd3qKp6qCgUc8RUsPdPBrRC6whFeWTg37DcmnJJiKFL73DH4sjdApJkXBD3vFcBP4xHq3fPY (111 chars) Smallest “possible” key: kS = 0x043583940000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000 (78 bytes) b58chk(kS) = tprv8ZgxMBicQKsPcsbCVeqqF1KVdH7gwDJbxbzpCxDUsoXHdb6SnTPYxdwSAKDC6KKJzv7khnNWRAJQsRA8BBQyiSfYnRt6zuu4vZQGKjeW4YF (111 chars)
murchandamus
requested changes
Apr 30, 2024
There was a problem hiding this comment.
I’m not sure how exactly this PR came together, but the change to BIP44 is no longer compatible with BIP44 after the "Compatible wallets" section got removed via #770.
If you would still like to pursue the changes to BIP16 and BIP32, it might be best if those changes were opened as separate PRs, given that they need sign-off from different authors.
|
Agree, closing. As the author was last active six years ago, I'll open separate BIP-specific pulls with a cherry-picked commit by the original author. |
jonatack
reviewed
Apr 30, 2024
| @@ -1,4 +1,4 @@ | |||
| This page is a Quality Assurance test plan for [[BIP 16]]. If you see a test missing, please add it. | |||
| This page is a Quality Assurance test plan for [[../bip-0016.mediawiki|BIP 16]]. If you see a test missing, please add it. | |||
There was a problem hiding this comment.
This has been fixed in 433283d.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Base58chk-encoded extended keys are always 111 characters long. Amend wording of BIP accordingly.
Diff:
-This results in a Base58-encoded string of up to 112 characters.
+This results in a Base58-encoded string of exactly 111 characters.
Proof:
Version bytes:
0x0488b21e(“xpub”),0x0488ade4(“xprv”),0x043587cf(“tpub”),0x04358394(“tprv”)Largest version byte is
0x0488b21e, smallest0x04358394.Largest “possible” key:
Smallest “possible” key: