Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BIP-85: Correct bad test vector for Base64 #1683

Merged
merged 1 commit into from
Oct 15, 2024
Merged

BIP-85: Correct bad test vector for Base64 #1683

merged 1 commit into from
Oct 15, 2024

Conversation

akarve
Copy link
Contributor

@akarve akarve commented Oct 14, 2024 •
edited by jonatack
Loading

@akarve akarve mentioned this pull request Oct 14, 2024
Merged
1 task
scgbckbone
scgbckbone approved these changes Oct 14, 2024
View reviewed changes
Copy link
Contributor

@scgbckbone scgbckbone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

jonatack referenced this pull request Oct 15, 2024
@jonatack
Revert "BIP85: Update/clarify spec, add change log, Portuguese langua…
3f4a0a1 
…ge code,…"

This reverts commit a1be309.
jonatack
jonatack reviewed Oct 15, 2024
View reviewed changes
Copy link
Member

@jonatack jonatack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 2e98c71

@jonatack jonatack merged commit 5284427 into bitcoin:master Oct 15, 2024
4 checks passed
@akarve akarve deleted the bip85-base64-vec-alone branch October 15, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonatack jonatack jonatack left review comments

@scgbckbone scgbckbone scgbckbone approved these changes

Assignees
No one assigned
Labels
Bug fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@akarve @jonatack @scgbckbone