BIP 387: multi_a() descriptor #1567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laanwj
reviewed
Apr 18, 2024
jonatack
reviewed
Apr 22, 2024
|
Assigned BIP 387. |
achow101
changed the title
jonatack
reviewed
Apr 23, 2024
achow101
force-pushed
the
multi_a
branch
2 times, most recently
from
1df09f4 to
4604171
Compare
jonatack
reviewed
May 1, 2024
jonatack
reviewed
May 1, 2024
achow101
force-pushed
the
multi_a
branch
2 times, most recently
from
01a467c to
fe8b1cb
Compare
jonatack
reviewed
May 6, 2024
jonatack
reviewed
May 6, 2024
|
LGTM fe8b1cb modulo 2 nits above |
Christewart
reviewed
May 6, 2024
|
|
||
| ==Abstract== | ||
|
|
||
| This document specifies <tt>multi_a()</tt> and <tt>sortedmulti_a()</tt> output script descriptors. |
There was a problem hiding this comment.
To ask the dumb question, what is a? add?
csa would be clearer IMO.
There was a problem hiding this comment.
The meaning of a is left for the reader to decide :p
(I don't think it has any meaning, just something to distinguish from multi. It's too late to change it since people are already using this.)
Some are. I pulled a few from there, although I don't think there were any |
|
ACK 945b281 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.