Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bip-tap: BIPs for the Taproot Assets Protocol #1489

Open
wants to merge 20 commits into
base: master
Choose a base branch
from

Commits on Sep 6, 2023

  1. Configuration menu
    Copy the full SHA
    c156b76 View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2023

  1. bip-tap-psbt: define value for asset version

    Using this, the vPSBT packet now contains the information required to
    have a distinct asset version for a given output.
    Roasbeef committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    270a9f9 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #42 from Roasbeef/bip-tap-psbt-asset-version

    bip-tap-psbt: define value for asset version
    Roasbeef authored Sep 28, 2023
    Configuration menu
    Copy the full SHA
    58b218e View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2023

  1. bip-tap-addr: sync TLV types

    guggero committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    257edb6 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2c8de88 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    7e3dfd9 View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2023

  1. Configuration menu
    Copy the full SHA
    1828353 View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2023

  1. Merge pull request #43 from guggero/tlv-re-numbering

    Use even/odd TLV numbers everywhere
    Roasbeef authored Oct 10, 2023
    Configuration menu
    Copy the full SHA
    666d60e View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2023

  1. bip-tap: clarify prev_asset_id and prev_asset_script_key

    To avoid confusing it with the "next" asset_script_key and asset_id, we
    rename the fields slightly.
    halseth authored and Roasbeef committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    f4c7324 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    373551d View commit details
    Browse the repository at this point in the history
  3. bip-tap: make minting witness encode asset internal key

    This let the verifier check that the `asset_group_key` is derived
    correctly from the internal key, and that the signature is valid.
    halseth authored and Roasbeef committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    67366eb View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    a25ef95 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    1b68510 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    cc3e1ce View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2023

  1. bip-tap-universe: split universe trees, use new sum values

    In this commit, we split the Universe trees into transfer vs issuance.
    The leaf sum value for issuance is the number of units, while for
    transfer just `1` (accumulator).
    
    For Multiverse trees, we make a similar distinction. The sum value for
    an issuance multiverse is just 1, so it tracks the total amount of
    assets committed to. For transfer multiverses, the value here is the
    same as the root of a transfer universe, this ends up summing to the
    total number of transfer committed to.
    Roasbeef committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    aeb9e47 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #45 from Roasbeef/split-universe-trees

    bip-tap-universe: split universe trees, use new sum values
    Roasbeef authored Oct 18, 2023
    Configuration menu
    Copy the full SHA
    6dd3458 View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2024

  1. bip-tap: correct asset_tree_root usage

    The field `asset_tree_root` is not 40 bytes long, but 32.
    
    This is both consistent with the implementation, and with the definition
    of the field further down in this bip.
    
    Definition:
    
    > the asset tree is calculated as either:
    > * <code>asset_tree_root = sha256(asset_id || left_hash || right_hash
    > || sum_value)</code>
    > or
    > * <code>asset_tree_root = sha256(asset_group_key || left_hash ||
    > right_hash || sum_value)</code>
    
    Implementation:
    
    ```
    leafParts := [][]byte{
      {byte(c.Version)}, TaprootAssetsMarker[:], rootHash[:],
      rootSum[:],
    }
    ```
    
    The bip now reflects this.
    gijswijs committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    71c83e5 View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2024

  1. Configuration menu
    Copy the full SHA
    deffebf View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    165fab1 View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2024

  1. Merge pull request #47 from gijswijs/fix-asset-tree-root-length

    bip-tap: correct `asset_tree_root` usage
    Roasbeef authored Nov 20, 2024
    Configuration menu
    Copy the full SHA
    66b5919 View commit details
    Browse the repository at this point in the history