Skip to content

memusage fixes #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
l0rinc wants to merge 17 commits into
base: master
Choose a base branch
from
Open

memusage fixes #139

l0rinc wants to merge 17 commits into from
+6,156 −31

Conversation

@l0rinc
Copy link
Collaborator

@l0rinc l0rinc commented Feb 25, 2025

Revival of the memusage related commits from https://github.com/bitcoin/bitcoin/pull/31102/commits by @andrewtoth

@l0rinc l0rinc changed the title memusage: move MallocUsage into separate file memusage fixes Feb 25, 2025
@github-actions
Copy link

github-actions bot commented Feb 26, 2025

📊 Benchmark results for this run (13530535498) will be available at: https://bitcoin-dev-tools.github.io/benchcoin/results/pr-139/13530535498/index.html after the github pages "build and deployment" action has completed.
🚀 Speedups: mainnet-default-instrumented: -0.0%, mainnet-large-instrumented: -1.8%, mainnet-default-uninstrumented: -1.7%, mainnet-large-uninstrumented: -0.8%

@github-actions github-actions bot force-pushed the master branch 4 times, most recently from 607732d to e0dab54 Compare March 4, 2025 03:28
@github-actions github-actions bot force-pushed the master branch 6 times, most recently from 3b99594 to 4098c1c Compare March 10, 2025 03:20
willcl-ark and others added 13 commits March 17, 2025 03:31
willcl-ark and others added 4 commits March 17, 2025 19:39
@willcl-ark
remove nightly upstream sync
f4e251d 
this just creates needless rebasing. Remove it.
@l0rinc
Add commit id to the plots to make sure they're not overwritten
e861169
@martinus @l0rinc
memusage: move MallocUsage into separate file
1175fe8 
That way it becomes usable in other code like allocators/pool
@martinus @l0rinc
memusage: pool keeps track of its memory usage
d12767a 
That way all containers that use the pool have accurate memory tracking.

Add test to show memory is accurately tracked, even when nodes can't be allocated by the pool.
The more accurate memory estimation interferes shows that our memory estimation for Windows
is off, as the real allocated memory is much higher. This adapts the memusage_test test so it still
works with the more correct estimation.
@github-actions
Copy link

github-actions bot commented Mar 20, 2025

📊 Benchmark results for this run (13949134586) will be available at: https://bitcoin-dev-tools.github.io/benchcoin/results/pr-139/13949134586/index.html after the github pages "build and deployment" action has completed.
🚀 Speedups: mainnet-default-uninstrumented: -2.6%, mainnet-large-uninstrumented: -0.4%

@l0rinc
Copy link
Collaborator Author

l0rinc commented Mar 20, 2025 •
edited
Loading

Sweet, the plots are working again:

base

head

base

head

@github-actions
Copy link

github-actions bot commented Mar 21, 2025

📊 Benchmark results for this run (13973974142) will be available at: https://bitcoin-dev-tools.github.io/benchcoin/results/pr-139/13973974142/index.html after the github pages "build and deployment" action has completed.
🚀 Speedups: mainnet-default-uninstrumented: 0.7%, mainnet-large-uninstrumented: -0.8%

@willcl-ark willcl-ark force-pushed the master branch 7 times, most recently from d216dc5 to 7f7e173 Compare October 29, 2025 02:02
@willcl-ark willcl-ark force-pushed the master branch 6 times, most recently from 5a6cd85 to d9d7b46 Compare December 10, 2025 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@l0rinc @willcl-ark @martinus