Test some refactoring of results.json #132
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: David Gumberg <[email protected]> Co-authored-by: Lőrinc <[email protected]>
Co-authored-by: fanquake <[email protected]>
This is still available in the testing repo: https://github.com/bitcoin-dev-tools/benchcoin-testing
davidgumberg
force-pushed
the
ZZZ-benchcoin-hyper-params
branch
from
96e0d35 to
cba9c07
Compare
davidgumberg
force-pushed
the
ZZZ-benchcoin-hyper-params
branch
from
cba9c07 to
f749b2d
Compare
github-actions
bot
force-pushed
the
master
branch
from
b21b38e to
b938c69
Compare
willcl-ark
reviewed
Feb 14, 2025
bench-ci/run-benchmark.sh
Outdated
Comment on lines
123
to
125
| --command-name "base (${base_commit})" \ | ||
| --command-name "head (${head_commit})" \ | ||
| "taskset -c 2-15 chrt -o 0 ${BINARIES_DIR}/{commit}/bitcoind -datadir=${TMP_DATADIR} -connect=${connect_address} -daemon=0 -prune=10000 -chain=${chain} -stopatheight=${stop_at_height} -dbcache=${dbcache} -printtoconsole=0" \ | ||
| -L commit "base,head" | ||
| "taskset -c 2-15 chrt -o 0 ${BINARIES_DIR}/{branch}/bitcoind -datadir=${TMP_DATADIR} -connect=${connect_address} -daemon=0 -prune=10000 -chain=${chain} -stopatheight=${stop_at_height} -dbcache=${dbcache} -printtoconsole=0" \ | ||
| -L branch "base,head" \ | ||
| -L commit "${base_commit},${head_commit}" # not used in the hyperfine command, but squeezing some more detail into the results.json |
There was a problem hiding this comment.
Needing to change this in two places already feels silly. I did wonder whether instrumented/un-instrumented should be two scripts or one (with more if branches), and felt that two probably made more sense, but now I'm not so sure...
github-actions
bot
force-pushed
the
master
branch
7 times, most recently
from
c556197 to
7862a78
Compare
github-actions
bot
force-pushed
the
master
branch
4 times, most recently
from
607732d to
e0dab54
Compare
github-actions
bot
force-pushed
the
master
branch
6 times, most recently
from
3b99594 to
4098c1c
Compare
github-actions
bot
force-pushed
the
master
branch
from
4912c0c to
91b2e42
Compare
willcl-ark
force-pushed
the
master
branch
7 times, most recently
from
d216dc5 to
7f7e173
Compare
willcl-ark
force-pushed
the
master
branch
6 times, most recently
from
5a6cd85 to
d9d7b46
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think the current arrangement of results.json quite makes sense, hoping this doesn't break anything