Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: update ecdsa_secp256k1_sha256_bitcoin_test.json #1638

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

tests: update ecdsa_secp256k1_sha256_bitcoin_test.json #1638

wants to merge 1 commit into from

Conversation

eltociear
Copy link

implemenation -> implementation

@real-or-random
Copy link
Contributor

This has been fixed upstream in C2SP/wycheproof#91 along with other changes. We should probably just reimport the file from upstream.

@real-or-random
Copy link
Contributor

real-or-random commented Nov 24, 2024 •
edited
Loading

The only other change is C2SP/wycheproof@875f85e , see https://github.com/C2SP/wycheproof/commits/master/testvectors_v1/ecdsa_secp256k1_sha256_bitcoin_test.json . @eltociear Can you include this in the PR here?

@real-or-random
Copy link
Contributor

We should also update these lines then:

secp256k1/src/wycheproof/WYCHEPROOF_COPYING

Lines 1 to 4 in 8deef00

* The file `ecdsa_secp256k1_sha256_bitcoin_test.json` in this directory
comes from Google's project Wycheproof with git commit
`b063b4aedae951c69df014cd25fa6d69ae9e8cb9`, see
https://github.com/google/wycheproof/blob/b063b4aedae951c69df014cd25fa6d69ae9e8cb9/testvectors_v1/ecdsa_secp256k1_sha256_bitcoin_test.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
refactor/smell
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eltociear @real-or-random