-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add silentpayments (BIP352) module #1471
Closed
theStack
wants to merge
13
commits into
bitcoin-core:master
from
theStack:silentpayments-module-demo
Closed
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
a9a5fe8
build: add skeleton for new silentpayments (BIP352) module
theStack 6e3ed2d
doc: add module description for secp256k1-silentpayments
theStack 81d1303
silentpayments: add private tweak data creation routine
theStack 98f5ba4
silentpayments: add public tweak data creation routine
theStack 842e5bf
silentpayments: add tweaked pubkey creation routine (for light client…
theStack b0e3796
silentpayments: add shared secret creation routine (a*B == A*b)
theStack 2a00e12
silentpayments: add label tweak calculation routine
theStack dbcccbb
silentpayments: add routine for creating labelled spend pubkeys (for …
theStack 8460be5
silentpayments: implement output pubkey creation (for sender)
theStack d6c9856
silentpayments: add routine for tx output scanning (for receiver)
theStack 26bdb5f
silentpayments: implement output spending privkey creation (for recei…
theStack 59488c4
tests: add BIP-352 test vectors
theStack e4ffa03
ci: enable silentpayments module
theStack File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the course of writing benchmarks, I just noticed that this scanning API is flawed from a performance perspective, as we currently recalculate$t_k$ and $P_{output}$ on every scanned output instead of only after the output counter $k$ is increased (that is, if a match was found). It seems that this routine should be split up into one calculating $P_{output}$ (only to be called once per $(B_{spend}, k)$ pair) and another one for calculating label candidates, given $P_{output}$ and $tx_{output}$ (to be called on each scanned output, if there's no match). So the $P_{output}$ and $tx_{output}$ .
direct_match
boolean out-parameter would go away (it was a bit weird anyway), as the caller would do the comparison between