Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci, doc: Document required actions #1408

Closed
wants to merge 1 commit into from

Conversation

hebasto
Copy link
Member

@hebasto hebasto commented Aug 21, 2023

Suggested in bitcoin/bitcoin#28173 (review):

I wonder if it makes sense to document the required permissions inside the file?

@real-or-random
Copy link
Contributor

Hm, isn't this clear from reading the files? I think that means that adding a comment is mostly an additional maintenance burden because we need to keep it up-to-date (and no tool complains if we forget).

Also, the required permissions are not canonical. You could also allow any action, or pin the actions to specific commit ids. All of these options would work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants