Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes _fe_equal_var, and unwanted _fe_normalize_weak calls (in tests) #1062

Merged
merged 2 commits into from
Aug 17, 2023
Merged

Removes _fe_equal_var, and unwanted _fe_normalize_weak calls (in tests) #1062

merged 2 commits into from
Aug 17, 2023

Commits on Aug 16, 2023

  1. tests: remove unwanted secp256k1_fe_normalize_weak call 

    It is not neccessary for the second argument in `secp256k1_fe_equal_var`
(or `secp256k1_fe_equal`) to have magnitude = 1.
Hence, removed the `secp256k1_fe_normalize_weak` call for those argument.
    @siv2r
    siv2r committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    bb4efd6 View commit details
    Browse the repository at this point in the history

  2. field: remove secp256k1_fe_equal_var 

    `fe_equal_var` hits a fast path only when the inputs are unequal, which is
uncommon among its callers (public key parsing, ECDSA verify).
    @siv2r
    siv2r committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    54058d1 View commit details
    Browse the repository at this point in the history