-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Optimize build matrix #1048
Closed
real-or-random
wants to merge
13
commits into
bitcoin-core:master
from
real-or-random:202112-ci-matrix
Closed
ci: Optimize build matrix #1048
real-or-random
wants to merge
13
commits into
bitcoin-core:master
from
real-or-random:202112-ci-matrix
Commits on Mar 16, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 1a6be57 - Browse repository at this point
Copy the full SHA 1a6be57View commit details -
Configuration menu - View commit details
-
Copy full SHA for cca8cbb - Browse repository at this point
Copy the full SHA cca8cbbView commit details
Commits on Mar 17, 2022
-
configure: Don't abort if the compiler does not define __STDC__
This removes a check for $ac_cv_prog_cc_c89 which is set by AC_PROG_CC if defined(__STDC__) in the preprocessor. (Standard compliant compilers are supposed to define __STDC__ to 1 but the value is actually not checked here.) Unfortunately, MSVC doesn't define it, so configure fails for MSVC. This check is not very useful in practice. Over 30 years after C89 has been released, there are no C compilers out there that are not sufficiently compliant with C89 for the project. The only practically relevant case was that the check rejected C++ compilers. A different method to reject C++ compilers will be introduced in a later commit.
Configuration menu - View commit details
-
Copy full SHA for 1cc0941 - Browse repository at this point
Copy the full SHA 1cc0941View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3b4f3d0 - Browse repository at this point
Copy the full SHA 3b4f3d0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 09f3d71 - Browse repository at this point
Copy the full SHA 09f3d71View commit details -
Configuration menu - View commit details
-
Copy full SHA for b97256d - Browse repository at this point
Copy the full SHA b97256dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3bdc4e0 - Browse repository at this point
Copy the full SHA 3bdc4e0View commit details -
This adds MSVC builds built on Linux using wine. This requires some settings of tools and flags because the autotools support for MSVC is naturally somewhat limited. The advantage of this approach is that it is compatible with our existing CI scripts, so there's no need to write a Windows CI script (in PowerShell or similar). If we want to test building and running on Windows native (e.g., as supported by Cirrus CI) we could still do this in the future. Another advantage of this approach is that contributors can simply use the docker image if they need a MSVC installation in a non-Windows environment. This commit also improves the Dockerfile by grouping RUN commands according to Docker docs: https://docs.docker.com/develop/develop-images/dockerfile_best-practices/#run
Configuration menu - View commit details
-
Copy full SHA for 6a9513f - Browse repository at this point
Copy the full SHA 6a9513fView commit details -
This commit also raises the TEST_ITERS for wine tasks to the default. The overhead of wine is negligible, so we can certainly afford the same number of iterations as for native Linux tests.
Configuration menu - View commit details
-
Copy full SHA for 93e9d11 - Browse repository at this point
Copy the full SHA 93e9d11View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0e31871 - Browse repository at this point
Copy the full SHA 0e31871View commit details
Commits on Mar 18, 2022
-
Configuration menu - View commit details
-
Copy full SHA for c16afd0 - Browse repository at this point
Copy the full SHA c16afd0View commit details
Commits on Mar 19, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 3a1a16c - Browse repository at this point
Copy the full SHA 3a1a16cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1c0a8ae - Browse repository at this point
Copy the full SHA 1c0a8aeView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.