Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update translation source file for v28.0 string freeze #833

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

hebasto
Copy link
Member

@hebasto hebasto commented Aug 13, 2024

This PR updates the src/qt/locale/bitcoin_en.xlf translation source file according to the Release schedule for 28.0.

Note for reviewers: it is expected to get a zero diff after running make -C src translate locally.

@DrahtBot
Copy link
Contributor

DrahtBot commented Aug 13, 2024

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process.

Type Reviewers
ACK stickies-v, pablomartin4btc

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

@hebasto hebasto added this to the 28.0 milestone Aug 13, 2024
@hebasto
Copy link
Member Author

hebasto commented Aug 13, 2024

Friendly ping @stickies-v @pablomartin4btc :)

Copy link
Contributor

@pablomartin4btc pablomartin4btc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 9edd8f3

Followed instructions resulting in no diff as expected.

Copy link
Contributor

@stickies-v stickies-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 9edd8f3

The diff is produced by running `make -C src translate`.
@hebasto
Copy link
Member Author

hebasto commented Aug 14, 2024

@pablomartin4btc @stickies-v

I had to update this PR due to the recently merged #824.

Sorry for invalidating your ACKs. Mind re-reviewing please?

@stickies-v
Copy link
Contributor

re-ACK 770b034

Copy link
Contributor

@pablomartin4btc pablomartin4btc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-ACK 770b034

no diffs.

@hebasto hebasto merged commit 9264d62 into bitcoin-core:master Aug 14, 2024
11 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants