Update Node window title with the chain type #758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
pablomartin4btc
force-pushed
the
gui-update-node-window-title
branch
from
8758730
to
91c19fc
Compare
pablomartin4btc
force-pushed
the
gui-update-node-window-title
branch
3 times, most recently
from
9091492
to
d062d32
Compare
Update Node window with the chain type except for mainnet. This replicates the behaviour of the main window.
pablomartin4btc
force-pushed
the
gui-update-node-window-title
branch
from
d062d32
to
9d37886
Compare
|
Thanks @BrandonOdiwuor for testing it. Main window is fine, this PR updates the title on the node window (e.g.: Main Menu->Window->Console).
It should work on any platform. |
BrandonOdiwuor
approved these changes
Nov 20, 2023
alfonsoromanz
approved these changes
Dec 22, 2023
kristapsk
approved these changes
Dec 27, 2023
hebasto
approved these changes
Feb 12, 2024
| const QString chainType = QString::fromStdString(Params().GetChainTypeString()); | ||
| const QString title = tr("Node window - [%1]").arg(chainType); | ||
| this->setWindowTitle(title); | ||
| } |
jess2505
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It fixes #544.
Enhance the Node window title by appending the chain type to it, except for the
mainnet, mirroring the behavior in the main window.There was also some interest on this while discussing network switching.