Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update translation source file for v25.0 string freeze #724

Merged
merged 12 commits into from
Apr 1, 2023

Conversation

hebasto
Copy link
Member

@hebasto hebasto commented Mar 31, 2023

This PR updates the src/qt/locale/bitcoin_en.xlf translation source file according to Release schedule for 25.0.

Some translation-related fixes have been picked from #599 and #716.

Note for reviewers: it is expected to get a zero diff after running make -C src translate locally.

@DrahtBot
Copy link
Contributor

DrahtBot commented Mar 31, 2023

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process.

Type Reviewers
ACK jarolrod

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

Conflicts

Reviewers, this pull request conflicts with the following ones:

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@hebasto
Copy link
Member Author

hebasto commented Mar 31, 2023

cc @luke-jr @furszy @jarolrod

Copy link
Member

@jarolrod jarolrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK e414edd

Went through the translation process again, confirming that plurals requires manual intervention in the translation source file.

I have a zero-diff with this branch after following the process steps.

@hebasto hebasto merged commit bc49a47 into bitcoin-core:master Apr 1, 2023
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Apr 2, 2023
@hebasto hebasto deleted the 230331-tr branch April 13, 2023 10:43
@bitcoin-core bitcoin-core locked and limited conversation to collaborators Apr 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants