Skip to content

Commit

Permalink
cmake, qt, test: Remove problematic code
Browse files Browse the repository at this point in the history
The removed code aimed to make Qt's minimal integration plugin DLL
available for `test_bitcoin-qt.exe` on Windows.

However, there are two issues:
1. The code is broken because the destination directory must end with a
   trailing slash (`/`).
2. It is unnecessary because Qt's minimal integration plugin is not
   used on Windows. For more details, please refer to the following
   code.
  • Loading branch information
hebasto committed Oct 24, 2024
1 parent d94adc7 commit fb46d57
Showing 1 changed file with 0 additions and 8 deletions.
8 changes: 0 additions & 8 deletions src/qt/test/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -32,14 +32,6 @@ if(ENABLE_WALLET)
)
endif()

if(NOT QT_IS_STATIC)
add_custom_command(
TARGET test_bitcoin-qt POST_BUILD
COMMAND ${CMAKE_COMMAND} -E copy_if_different $<TARGET_PROPERTY:Qt5::QMinimalIntegrationPlugin,LOCATION_$<UPPER_CASE:$<CONFIG>>> $<TARGET_FILE_DIR:test_bitcoin-qt>/plugins/platforms
VERBATIM
)
endif()

add_test(NAME test_bitcoin-qt
COMMAND test_bitcoin-qt
)
Expand Down

0 comments on commit fb46d57

Please sign in to comment.