Bugfix: GUI: Display error messagebox (rather than stderr) when exter…

…nal signer fails inexplicably
bitcoin-core · Jun 29, 2023 · e119c5a · e119c5a
1 parent 1476090
commit e119c5a
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/src/qt/sendcoinsdialog.cpp b/src/qt/sendcoinsdialog.cpp
@@ -466,8 +466,9 @@ bool SendCoinsDialog::signWithExternalSigner(PartiallySignedTransaction& psbtx,
         return false;
     }
     if (err != TransactionError::OK) {
-        tfm::format(std::cerr, "Failed to sign PSBT");
         processSendCoinsReturn(WalletModel::TransactionCreationFailed);
+        const QString msg = tr("Failed to sign PSBT");
+        QMessageBox::critical(nullptr, msg, msg);
         return false;
     }
     // fillPSBT does not always properly finalize