Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: next #4760

Draft
wants to merge 74 commits into
base: main
Choose a base branch
from
Draft

chore: next #4760

wants to merge 74 commits into from
+26,540 −20,539

Conversation

ematipico
Copy link
Member

Summary

Test Plan

ematipico and others added 30 commits November 27, 2024 16:13
@ematipico
feat: remove support for rome-ignore (#4252)
36b4b1c
@ematipico
feat: remove --apply and --apply-unsafe (#4268)
0425b90
@ematipico
fix: reduce accepted values for options (#4271)
72ef826
@ematipico
feat: remove trailingComma option (#4266)
1accca5
@ematipico
feat: remove --indent-size (#4270)
1be9494
@ematipico
feat: remove environment variable BIOME_LOG_DIR (#4289)
17ff3f6
@Conaclos @ematipico
refactor: remove dead code (#4291)
8e950b6
@ematipico
feat: rename biome_rowan methods (#4297)
82ef3ce
@ematipico
fix: use new methods
b0bf177
@arendjr @ematipico
feat: plugin loader (#4234)
8b129ea
@ematipico
update snapshots
63eece0
@ematipico
chore: update other snapshots
9733e34
@ematipico
feat(analyzer): top level suppression (#4306)
0680ba5
@arendjr @ematipico
chore: normalize Windows paths in plugin tests (#4362)
d912491
@ematipico
feat(parser/js): remove assert syntax (#4360)
6a8ad85
@Conaclos @ematipico
refactor(biome_deserialize): add deserilization context (#4166)
889cd5e
@ematipico
chore: fix merge issues
57c64b4
@ematipico
feat: useExhaustiveDependencies not recommended (#4294)
74eaf89
@dyc3 @ematipico
refactor(parser/js): rename import assertions to import attributes (#…
da6d229 
…4373)
@ematipico @arendjr
feat(workspace): make types camel case (#4368)
d469189 
Co-authored-by: Arend van Beelen jr <[email protected]>
@ematipico
chore: update code and diagnostics (#4397)
b2ca29e
@Conaclos @ematipico
refactor(biome_deserialize): add indexmap Cargo feature and remove …
bb66d05 
…StringSet (#4387)
@arendjr @ematipico
feat(linter): analyzer plugin (#4396)
b5b6caa
@arendjr @ematipico
feat(grit): support until clause in within patterns (#4399)
e955488
@ematipico
fix regressions
3a28618
@Conaclos @ematipico
ci: fix errors and update snapshots (#4441)
8c6e9b4
@Conaclos @ematipico
refactor: reduce dependency on indexmap (#4439)
59f7e10
@arendjr @ematipico
feat(grit): support Grit queries targeting CSS (#4444)
63201a9
@arendjr @ematipico
feat(grit): implement CSS plugins (#4448)
7f0bb2a
@ematipico
feat(cli): change how behaves with large files (#4474)
3936022
@github-actions github-actions bot added A-CLI Area: CLI A-Core Area: core A-Project Area: project A-Linter Area: linter A-Parser Area: parser A-Formatter Area: formatter A-Tooling Area: internal tools A-LSP Area: language server protocol L-JavaScript Language: JavaScript and super languages L-CSS Language: CSS L-JSON Language: JSON and super languages A-Diagnostic Area: diagnostocis A-Changelog Area: changelog L-HTML Language: HTML L-Grit Language: GritQL labels Dec 19, 2024
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Dec 19, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #4760 will degrade performances by 6.44%

Comparing next (1907096) with main (a4db155)

Summary

❌ 1 regressions
✅ 96 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main next Change
❌ js_analyzer[lint_13640784270757307929.ts] 33.5 ms 35.8 ms -6.44%

@ematipico ematipico changed the title Next chore: next Dec 19, 2024
@arendjr
Copy link
Contributor

arendjr commented Dec 19, 2024 •
edited
Loading

Please take care to merge instead of squash this one, or we flatten a month of history 😉

@ematipico
Copy link
Member Author

ematipico commented Dec 19, 2024 •
edited
Loading

Please take care to merge instead of squash this one, or we flatten a month of history 😉

For this one PR, we must merge it using "merge commits" (not squash), otherwise all commits gets squashed and the attribution belongs only to the person that opened the PR.

@ematipico
Copy link
Member Author

@arendjr can you block the PR to avoid accidental merges?

arendjr
arendjr requested changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@arendjr arendjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reminder to merge instead of squash:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arendjr arendjr arendjr requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
A-Changelog Area: changelog A-CLI Area: CLI A-Core Area: core A-Diagnostic Area: diagnostocis A-Formatter Area: formatter A-Linter Area: linter A-LSP Area: language server protocol A-Parser Area: parser A-Project Area: project A-Tooling Area: internal tools L-CSS Language: CSS L-Grit Language: GritQL L-HTML Language: HTML L-JavaScript Language: JavaScript and super languages L-JSON Language: JSON and super languages
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ematipico @arendjr @Conaclos @dyc3 @unvalley