-
-
Notifications
You must be signed in to change notification settings - Fork 503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(lint): add rule noJsxPropsBind #4639
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor notes before you get too deep
/// | ||
pub NoBind { | ||
version: "next", | ||
name: "noBind", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like we can come up with a better name than noBind
. At the very least, it should mention "Jsx" since this rule should only apply to Jsx.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I see😅.
However, I've noticed that some existing JSX rules include "jsx" in their names while others do not. Maybe need to standardize "Jsx" naming convention.
pub NoBind { | ||
version: "next", | ||
name: "noBind", | ||
language: "js", | ||
recommended: false, | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't have a rule source
Summary
Implement react/jsx-no-bind
Test Plan