Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable GraphQL linting #3350

Merged
merged 5 commits into from
Jul 8, 2024
Merged

feat: enable GraphQL linting #3350

merged 5 commits into from
Jul 8, 2024

Conversation

ematipico
Copy link
Member

@ematipico ematipico commented Jul 4, 2024

Summary

This PR enabled GraphQL linting via CLI, it adds the relative configuration to biome.json file.

Test Plan

I added tests for formatting and linting

@github-actions github-actions bot added A-CLI Area: CLI A-Project Area: project A-Changelog Area: changelog labels Jul 4, 2024
Copy link

codspeed-hq bot commented Jul 4, 2024

CodSpeed Performance Report

Merging #3350 will degrade performances by 8.76%

Comparing chore/enable-graphql (9ee576e) with main (40727ca)

Summary

❌ 2 regressions
✅ 106 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main chore/enable-graphql Change
react.production.min_3378072959512366797.js[cached] 1.9 ms 2 ms -6.55%
db_2930068967297060348.json[cached] 12.6 ms 13.8 ms -8.76%

@ematipico ematipico marked this pull request as ready for review July 4, 2024 12:18
@ematipico ematipico requested review from a team July 4, 2024 12:18
@ematipico
Copy link
Member Author

ematipico commented Jul 4, 2024

I wanted to make the GraphQL linting and formatting opt-in, but due to the issue created by Partial, the linting is enabled by default. Hopefully #3317 will fix this

@ematipico ematipico force-pushed the chore/enable-graphql branch from d2cd1b0 to 9ee576e Compare July 7, 2024 19:12
@ematipico ematipico merged commit f2b49c0 into main Jul 8, 2024
14 of 15 checks passed
@ematipico ematipico deleted the chore/enable-graphql branch July 8, 2024 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Changelog Area: changelog A-CLI Area: CLI A-Project Area: project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants