Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

recipe for scROSHI package based on CRAN repo #52783

Merged
merged 3 commits into from
Jan 9, 2025

Conversation

vipints
Copy link
Contributor

@vipints vipints commented Dec 13, 2024

Trying to add scROSHI package to bioconda

Comment on lines 24 to 29
- r-base ==4.3.2
- bioconductor-s4vectors ==0.40.2
- bioconductor-singlecellexperiment ==1.24.0
- bioconductor-summarizedexperiment ==1.32.0
- bioconductor-limma ==3.58.1
- r-uwot ==0.1.16
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are those strict pins really needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bgruening, I have tested the installation with the above package versions. I am not quite sure whether the dependency conflict arises if this is not mentioned explicitly. Let me test that as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested and there are no version constraints for the packages but there is a minimum version for r-base: >=3.6.0

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, then please remove those contraints :) Thanks.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@bgruening bgruening enabled auto-merge (squash) January 9, 2025 08:14
@bgruening bgruening merged commit e97801a into bioconda:master Jan 9, 2025
5 checks passed
stuber pushed a commit to stuber/bioconda-recipes that referenced this pull request Feb 7, 2025
* bioconda recipe conf for scROSHI package

* discarded strict package version constraints

* Update meta.yaml

---------

Co-authored-by: Björn Grüning <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants