Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for armel (ARMv5) architecture #704

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ant9000
Copy link

@ant9000 ant9000 commented Apr 18, 2023

Straightforward patch for armel arch (ARMv5 soft-float) support.

Thanks a bunch for your wonderful project!

@binwiederhier
Copy link
Owner

  1. I removed ARMv5 support at some point for some reason. I forgot what it was. I think it had to do with the Debian repo software (aptly) not being able to deal with two different arm versions or something. If you look through the tickets you may find it.

Try doing a make release-snapshot and see if there are any issue with the .deb packages, maybe list them here.

  1. You'll need to update the install.md file too for the docs, assuming that (1) is not an issue.

@ant9000 ant9000 force-pushed the pr_armel_support branch 2 times, most recently from a7c477a to a1948cd Compare April 18, 2023 17:08
@ant9000
Copy link
Author

ant9000 commented Apr 18, 2023

Wasn't able to find any reference to ARMv5/armel in past issues, but I see your point with regards to aptly: you have two different packages for the same architecture, since ARMv6 and ARMv7 are both armhf.
This should not be a problem with ARMv5, since the architecture is armel, which is indeed different.
I've done a make release-snapshot and spotted a few places where my first patch was incomplete - now it generates all the packages, and not only the binary executable.
I've added the relevant sections to install.md too.

PS: developer docs fail to mention a dependence on docker.

.goreleaser.yml Outdated
use: buildx
dockerfile: Dockerfile
goarch: arm
goarm: 6
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

6?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoopsie 😊 Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants