No exit when union_helper not found #99
Conversation
There was a problem hiding this comment.
Test cases worked on machines with mergerfs.
try now behaves correctly with machines nested mount and no unionfs/mergerfs.
eric@try-test-lvm:/srv$ /home/eric/try/try echo hi
try(/tmp/tmp.dRGKQR7sz5): Warning: Failed mounting /home as an overlay and mergerfs or unionfs not set and could not be found, see "/tmp/tmp.5rnwzXMHdm"
try(/tmp/tmp.dRGKQR7sz5): Warning: Failed mounting /run as an overlay and mergerfs or unionfs not set and could not be found, see "/tmp/tmp.5rnwzXMHdm"
try(/tmp/tmp.dRGKQR7sz5): Warning: Failed mounting /sys as an overlay and mergerfs or unionfs not set and could not be found, see "/tmp/tmp.5rnwzXMHdm"
try(/tmp/tmp.dRGKQR7sz5): Warning: Failed mounting /home as an overlay and mergerfs or unionfs not set and could not be found, see "/tmp/tmp.5rnwzXMHdm"
hi
home is repeated here
- one re-run was caused by /home being a mount(listed in findmnt)
- the other re-run is caused by the initial mounting of /home failing because it is a nested mount
Is this something that we want to look into or is this fine?
We should try to avoid duplicate work... and we should definitely avoid redundant warnings/output. Definitely worth fixing, especially if it's easy. |
I think this is caused by |
|
On Thu Jul 6, 2023 at 4:57 PM EDT, Konstantinos Kallas wrote:
I think this is caused by `for mountpoint in /* $(findmnt --real -r -o target -n)` which lists both all top level directories and then all mounts. This is an issue that we figured out we need to solve indeed (but it doesn't have anything to do with my PR).
Perhaps we should move this to a separate issue and handle it outside of
this PR.
… --
Reply to this email directly or view it on GitHub:
#99 (comment)
You are receiving this because your review was requested.
Message ID: ***@***.***>
|
|
I think the repeating of home also has to do with the first part of this issue (#104) |
|
I think it is related to that, but the solution for the first part of
the issue is to make separate tempdirs to store the helper directories
for the nested mounts.
For this we want to make sure we only try to mount them once, probably
by removing the duplicates from `/*` and `findmnt --real -r -o target
-n`
Possible in the findmnt loop, we check if $mountpoint is in /*
|
|
OK, fixed the duplicate issue too @ericzty can you check you dont get the warning for home twice? @mgree could you check the new changes? |
There was a problem hiding this comment.
eric@try-test-lvm:/srv$ /home/eric/try/try echo hi
try(/tmp/tmp.4B1SvKhn8b): Warning: Failed mounting /home as an overlay and mergerfs or unionfs not set and could not be found, see "/tmp/tmp.NJCocX3VGY"
try(/tmp/tmp.4B1SvKhn8b): Warning: Failed mounting /run as an overlay and mergerfs or unionfs not set and could not be found, see "/tmp/tmp.NJCocX3VGY"
try(/tmp/tmp.4B1SvKhn8b): Warning: Failed mounting /sys as an overlay and mergerfs or unionfs not set and could not be found, see "/tmp/tmp.NJCocX3VGY"
hi
🚀
This PR fixes try to not exit when unionfs/mergerfs are not found, but just produce warning messages.
Addresses: #96