-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Thredds harvest #86
base: master
Are you sure you want to change the base?
Thredds harvest #86
Conversation
… test-schema-org
…to thredds_harvest
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there are some dependencies listed here that don't appear to be used.
i'd like to avoid urllib3 and focus url interactions on requests, for example
please confirm whether these dependencies are needed
pydap | ||
requests-futures | ||
owslib | ||
urllib3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this dependency doesn't appear to be used anywhere
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
threddsnc2rdf.py uses the urljoin/split/parse functions of urllib3/urllib.
nc2rdf/requirements.txt
Outdated
requests-futures | ||
owslib | ||
urllib3 | ||
python-dateutil |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this dependency doesn't appear to be used anywhere
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the code used to use the parser function. seems like it doesn't now. it can go.
nc2rdf/requirements.txt
Outdated
@@ -0,0 +1,6 @@ | |||
lxml | |||
pydap | |||
requests-futures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this dependency doesn't appear to be used anywhere
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
requests-futures could probably go
This PR features a tool called threddsnc2rdf.py.
threddsnc2rdf.py provides the ability to pass in a THREDDS or THREDDS catalog endpoint to then crawl any netCDF file and output BALD RDF or Schema.org json-ld descriptions .
Examples:
Example BALD RDF output
Example schema.org output