This repository has been archived by the owner on May 21, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 7
Add TypeScript function example #56
Open
rylandg
wants to merge
3
commits into
master
Choose a base branch
from
feature-typescript-function
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
# TypeScript function (NodeJS and TypeScript) | ||
|
||
Boilerplate setup for a Binaris function written in TypeScript | ||
|
||
It is assumed you already have a Binaris account. If you don't have an account yet, worry not, signing up is painless and takes just 2 minutes. Visit [Getting Started](https://dev.binaris.com/tutorials/nodejs/getting-started/) to find concise instructions for the process. | ||
|
||
## Using the function | ||
|
||
1. Install dev-dependencies needed to compile TypeScript. | ||
|
||
```bash | ||
$ npm install | ||
``` | ||
|
||
1. Compile the TypeScript function for Binaris deployment. | ||
|
||
```bash | ||
$ npm run build | ||
``` | ||
|
||
1. Deploy the function. | ||
|
||
```bash | ||
$ bn deploy typescript | ||
``` | ||
|
||
1. Invoke. | ||
|
||
```bash | ||
$ bn invoke typescript | ||
"Hello World!" | ||
``` | ||
|
||
> Note: The "npm run deploy" script is a convenience target that compiles and deploys your TypeScript function |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
functions: | ||
typescript: | ||
file: dist/function.js | ||
entrypoint: handler | ||
executionModel: concurrent | ||
runtime: node8 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
{ | ||
"name": "typescript-function", | ||
"version": "1.0.0", | ||
"private": true, | ||
"license": "MIT", | ||
"description": "A demo showing a common TypeScript setup on Binaris", | ||
"main": "dist/index.js", | ||
"repository": { | ||
"type": "git", | ||
"url": "git+https://github.com/binaris/functions-examples.git" | ||
}, | ||
"scripts": { | ||
"deploy": "npm run build && bn deploy typescript", | ||
"build": "tsc --p tsconfig.json", | ||
"lint": "tslint -p tsconfig.json -c tslint.yml" | ||
}, | ||
"bugs": { | ||
"url": "https://github.com/binaris/functions-examples/issues" | ||
}, | ||
"homepage": "https://github.com/binaris/functions-examples/typescript-function/README.md", | ||
"author": "Ryland Goldstein", | ||
"dependencies": {}, | ||
"devDependencies": { | ||
"@types/node": "^11.11.3", | ||
"tslint": "^5.14.0", | ||
"typescript": "^3.3.3333" | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
/// <reference types="node" /> | ||
interface BinarisHTTPRequest { | ||
env: Record<string, string | undefined>; | ||
query: Record<string, string | string[] | undefined>; | ||
body: Buffer; | ||
path: string; | ||
method: string; | ||
requestId: string; | ||
headers: Record<string, string | string[] | undefined>; | ||
} | ||
|
||
interface FunctionResponse { | ||
statusCode: number; | ||
headers: Record<string, string | undefined>; | ||
body: Buffer | string; | ||
} | ||
|
||
declare class BinarisHTTPResponse implements FunctionResponse { | ||
userResponse: Partial<FunctionResponse>; | ||
constructor(userResponse: Partial<FunctionResponse>); | ||
statusCode: number; | ||
headers: Record<string, string | undefined>; | ||
body: Buffer | string; | ||
} | ||
|
||
declare type FunctionContext = { | ||
request: BinarisHTTPRequest; | ||
HTTPResponse: typeof BinarisHTTPResponse; | ||
}; | ||
|
||
export declare type BinarisFunction = (body: unknown, context: FunctionContext) => Promise<any> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
import { BinarisFunction } from './binaris'; | ||
|
||
interface DataWithName { name: string; } | ||
|
||
function bodyHasName(body: unknown): body is DataWithName { | ||
return body && typeof (body as DataWithName).name === 'string'; | ||
} | ||
|
||
export const handler: BinarisFunction = async (body, ctx): Promise<string> => { | ||
let name: string | undefined; | ||
if (typeof(ctx.request.query.name) === 'string') { | ||
name = ctx.request.query.name; | ||
} else if (bodyHasName(body)) { | ||
name = name || body.name; | ||
} | ||
name = name || 'World'; | ||
return `Hello ${name}!`; | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,61 @@ | ||
{ | ||
"compilerOptions": { | ||
/* Basic Options */ | ||
"module": "commonjs", /* Specify module code generation: 'none', 'commonjs', 'amd', 'system', 'umd', 'es2015', or 'ESNext'. */ | ||
"outDir": "./dist", | ||
// "allowJs": true, /* Allow javascript files to be compiled. */ | ||
// "checkJs": true, /* Report errors in .js files. */ | ||
// "jsx": "preserve", /* Specify JSX code generation: 'preserve', 'react-native', or 'react'. */ | ||
// "declaration": true, /* Generates corresponding '.d.ts' file. */ | ||
// "declarationMap": true, /* Generates a sourcemap for each corresponding '.d.ts' file. */ | ||
// "sourceMap": true, /* Generates corresponding '.map' file. */ | ||
// "outFile": "./", /* Concatenate and emit output to single file. */ | ||
// "outDir": "./", /* Redirect output structure to the directory. */ | ||
// "rootDir": "./", /* Specify the root directory of input files. Use to control the output directory structure with --outDir. */ | ||
// "composite": true, /* Enable project compilation */ | ||
// "removeComments": true, /* Do not emit comments to output. */ | ||
// "noEmit": true, /* Do not emit outputs. */ | ||
// "importHelpers": true, /* Import emit helpers from 'tslib'. */ | ||
// "downlevelIteration": true, /* Provide full support for iterables in 'for-of', spread, and destructuring when targeting 'ES5' or 'ES3'. */ | ||
// "isolatedModules": true, /* Transpile each file as a separate module (similar to 'ts.transpileModule'). */ | ||
|
||
/* Strict Type-Checking Options */ | ||
"strict": true, /* Enable all strict type-checking options. */ | ||
// "noImplicitAny": true, /* Raise error on expressions and declarations with an implied 'any' type. */ | ||
// "strictNullChecks": true, /* Enable strict null checks. */ | ||
// "strictFunctionTypes": true, /* Enable strict checking of function types. */ | ||
// "strictBindCallApply": true, /* Enable strict 'bind', 'call', and 'apply' methods on functions. */ | ||
// "strictPropertyInitialization": true, /* Enable strict checking of property initialization in classes. */ | ||
// "noImplicitThis": true, /* Raise error on 'this' expressions with an implied 'any' type. */ | ||
// "alwaysStrict": true, /* Parse in strict mode and emit "use strict" for each source file. */ | ||
|
||
/* Additional Checks */ | ||
// "noUnusedLocals": true, /* Report errors on unused locals. */ | ||
// "noUnusedParameters": true, /* Report errors on unused parameters. */ | ||
// "noImplicitReturns": true, /* Report error when not all code paths in function return a value. */ | ||
// "noFallthroughCasesInSwitch": true, /* Report errors for fallthrough cases in switch statement. */ | ||
|
||
/* Module Resolution Options */ | ||
// "moduleResolution": "node", /* Specify module resolution strategy: 'node' (Node.js) or 'classic' (TypeScript pre-1.6). */ | ||
// "baseUrl": "./", /* Base directory to resolve non-absolute module names. */ | ||
// "paths": {}, /* A series of entries which re-map imports to lookup locations relative to the 'baseUrl'. */ | ||
// "rootDirs": [], /* List of root folders whose combined content represents the structure of the project at runtime. */ | ||
// "typeRoots": [], /* List of folders to include type definitions from. */ | ||
// "types": [], /* Type declaration files to be included in compilation. */ | ||
// "allowSyntheticDefaultImports": true, /* Allow default imports from modules with no default export. This does not affect code emit, just typechecking. */ | ||
"esModuleInterop": true /* Enables emit interoperability between CommonJS and ES Modules via creation of namespace objects for all imports. Implies 'allowSyntheticDefaultImports'. */ | ||
// "preserveSymlinks": true, /* Do not resolve the real path of symlinks. */ | ||
|
||
/* Source Map Options */ | ||
// "sourceRoot": "", /* Specify the location where debugger should locate TypeScript files instead of source locations. */ | ||
// "mapRoot": "", /* Specify the location where debugger should locate map files instead of generated locations. */ | ||
// "inlineSourceMap": true, /* Emit a single file with source maps instead of having a separate file. */ | ||
// "inlineSources": true, /* Emit the source alongside the sourcemaps within a single file; requires '--inlineSourceMap' or '--sourceMap' to be set. */ | ||
|
||
/* Experimental Options */ | ||
// "experimentalDecorators": true, /* Enables experimental support for ES7 decorators. */ | ||
// "emitDecoratorMetadata": true, /* Enables experimental support for emitting type metadata for decorators. */ | ||
}, | ||
"exclude": [ "node_modules" ], | ||
"include": [ "./src/**/*.ts" ] | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,54 @@ | ||
defaultSeverity: error | ||
extends: | ||
- 'tslint:recommended' | ||
jsRules: | ||
rules: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. again, very very verbose. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. as above, These are literally our own rules from |
||
quotemark: | ||
- true | ||
- single | ||
- avoid-escape | ||
- avoid-template | ||
curly: | ||
- true | ||
- ignore-same-line | ||
max-classes-per-file: false | ||
no-implicit-dependencies: | ||
- true | ||
- dev | ||
variable-name: | ||
- true | ||
- ban-keywords | ||
- check-format | ||
- allow-leading-underscore | ||
interface-name: false | ||
member-ordering: false | ||
object-literal-sort-keys: false | ||
ordered-imports: false | ||
object-literal-key-quotes: [true, "as-needed"] | ||
trailing-comma: | ||
- true | ||
- multiline: | ||
objects: always | ||
arrays: always | ||
typeLiterals: always | ||
singleline: | ||
functions: never | ||
esSpecCompliant: true | ||
whitespace: | ||
- true | ||
- check-branch | ||
- check-decl | ||
- check-operator | ||
- check-module | ||
- check-separator | ||
- check-rest-spread | ||
- check-type | ||
- check-typecast | ||
- check-type-operator | ||
- check-preblock | ||
|
||
rulesDirectory: [] | ||
linterOptions: | ||
exclude: | ||
- '**/node_modules/**.ts' | ||
- '**/*.js' |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why so complex?
I think the following is simpler, does not use coercion nor immutable variables.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have to think about this. I'm not sure I entirely agree. There is more to consider than just writing the most concise code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that typescript compiler does not accept it in strict mode (E: Element implicitly has an 'any' type because type '{}' has no index signature.)
The
unknown
type almost forces coercion - perhaps it is too strict and we should publish the interface withany
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
100% agree. I think the existing code (my original + vlads revisions) is the best solution while we have
body
asunknown
. If we change that component, your solution makes a lot of sense.