fix: improve Spectre test console output capture and documentation #548
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix AnsiTestConsole.AllText() and OutText() to properly separate stdout/stderr - AllText() now combines Spectre output (stdout) with base.ErrorText() (stderr) - OutText() returns only stdout from SpectreTestConsole to avoid duplication - Added detailed XML docs explaining output capture architecture - Add ToString() override to DuplexTextWriter - Delegates to Listener writer for proper output retrieval in tests - Added comprehensive XML documentation - Enhance AnsiConsoleForwardingConsole documentation - Document production vs testing usage scenarios - Explain internal constructor purpose for test capture - Add comprehensive test coverage for AnsiTestConsole - Test DuplexTextWriter.ToString() behavior - Test IAnsiConsole and Console.Out output capture - Test Spectre markup rendering (plain text and ANSI codes) - Test mixed Console and Spectre output scenarios
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix AnsiTestConsole.AllText() and OutText() to properly separate stdout/stderr
Add ToString() override to DuplexTextWriter
Enhance AnsiConsoleForwardingConsole documentation
Add comprehensive test coverage for AnsiTestConsole