Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Handle seconds instead of milliseconds #10

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Fix] Handle seconds instead of milliseconds #10

wants to merge 1 commit into from

Conversation

AnotherRegularDude
Copy link

Problem

Gruf::Prometheus::Server::Collector#handled_latency_seconds uses Gruf::Interceptors::Timer.time to measure how many seconds it takes to perform the procedure. But, according to your other gem Gruf, the result of calling time method represented in milliseconds, not seconds.

So, I fixed the issue by multiplying result by 1_000

How was it tested?

Watch at Grafana graphs =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@AnotherRegularDude