Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: Document the validation model, context and inheritance principle #94
doc: Document the validation model, context and inheritance principle #94
Changes from all commits
b3159f8
5574bee
4057847
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
where in validator we would apply inheritance's walkBack to
.tsv
files? e.g. if there is top levelsessions.tsv
and thensub-01/sub-01_sessions.tsv
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BIDS does not have this concept yet, so the validator does not have it. We would need to define it to know whether
walkBack
is even applicable (augmentsub-01_sessions.tsv
withsessions.tsv
), or if we need to construct one global table (augmentsessions.tsv
withsub-*_sessions.tsv
).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To what
.tsv
files we have that principle applied so far ?We do list not only
.json
but also.bvec
and.tsv
files in https://github.com/bids-standard/bids-specification/blob/master/src/common-principles.md#the-inheritance-principleThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, those are the associated files, see a couple lines down from here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I do not see any kind of "inheritance" operation there though like here
| sidecar
-- there it just returns first found instead of "building up" the value.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From https://bids-specification.readthedocs.io/en/stable/common-principles.html#rules: