Support multi-value fitler and negation filter support for parse and search commands#103
Merged
Support multi-value fitler and negation filter support for parse and search commands#103
parse and search commands#103Conversation
- Change ParseFilters fields to Vec<String> for multiple value support - Support comma-separated values: -o 13335,15169,8075 - Support negation with ! prefix: -o '!13335' - Add validation for ASN format and prefix CIDR notation - Upgrade bgpkit-parser to 0.15.0 for OR-logic filter support - Update examples to use new Vec<String> filter types
- Gate entire database module at lib.rs level with #[cfg(feature = "database")] - Remove redundant feature gates from internal database submodules - Add feature gates to config functions that depend on database types - Re-export RpkiAspaEnrichedRecord and RpkiAspaProviderEnriched - Update lib.rs doc example to use new Vec<String> filter API - Add detailed feature documentation to ARCHITECTURE.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add multi-value OR filters and negation support for
parseandsearchcommands, leveraging bgpkit-parser 0.15.0's new filter capabilities.New Features
Multi-value filters (OR logic)
Filter by multiple values using comma-separated lists. Elements matching ANY of the specified values are included:
Negation filters (exclusion)
Exclude elements using the
!prefix:Note: Positive and negative values cannot be mixed in the same filter.
Input validation
Added validation with clear error messages:
!and non-!values)Breaking Changes
ParseFiltersfield types changed to support multiple values:origin_asnOption<u32>Vec<String>prefixOption<String>Vec<String>peer_asnOption<u32>Vec<String>Library users need to update their code:
Other Changes
databasemodule to simplify conditional compilationRelated issues
#97