a replacement should become as simple as:

I think the replacement needs something more, since some maps disable this logic, so wupget code should be able to apply the same heuristic (not sure what it is about but it's controlled per map so I think some may be disabling it?).

Here is the final proposed widget to archieve autoshowmetal in a backwards compatible way (ie, respecting the map autoshowmetal declaration):

examples/Widgets/gui_autoshowmetal.lua

Here is the final proposed widget to archieve autoshowmetal in a backwards compatible way (ie, respecting the map autoshowmetal declaration):

examples/Widgets/gui_autoshowmetal.lua

Does it need to be respected? I don't think this is a value that mappers have ever been setting with forethought, moreso just carrying on whatever the value the base project had.

In what situations would you not want autoshowmetal = true?

In what situations would you not want autoshowmetal = true?

Maybe for full-metal maps? No idea tbh just made the lua version to be fully compatible with current c++ code and also to address @lhog concerns.

In what situations would you not want autoshowmetal = true?

Maybe for full-metal maps? No idea tbh just made the lua version to be fully compatible with current c++ code and also to address @lhog concerns.

If disabling autoshowmetal on metal maps is the goal then respecting set map configured value isn't going to work, from a quick inspection at the very least Full Metal Plate and Adamantium Factory have autoshowmetal = true.

If disabling autoshowmetal on metal maps is the goal then respecting set map configured value isn't going to work, from a quick inspection at the very least Full Metal Plate and Adamantium Factory have autoshowmetal = true.

Well, maybe those maps where supposed to use it but meaning was long forgot by time, what can I say, just replicated the c++ code to make sure not breaking anything we don't know about... maybe the 100+ maps all set it to true? No idea but it's very possible that had some reason for existing and could even be in use.

Anyways, the goal is simply to have a fully compatible implementation so eventually we'll get rid of the c++ one and let games do as they wish with that.