Skip to content

Conversation

@Yaribz
Copy link
Contributor

@Yaribz Yaribz commented Apr 23, 2025

fix #58

Copy link
Collaborator

@p2004a p2004a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This particular verbose is very helpful for debugging, so I don't want to disable it unconditionally always.

Either:

  • disable only when disable-loggins is set
  • add option to enable at runtime

@Yaribz
Copy link
Contributor Author

Yaribz commented Apr 27, 2025

I thought it was a mistake (according to the commit messages, as explained in #58 ), and that the debug messages weren't supposed to be printed anymore. I was just trying to restore the expected behavior. I don't plan to add new features in pr-downloader, so if current behavior is already the expected one then all is good (I have already worked around it in SPADS anyway).

@Yaribz Yaribz closed this Apr 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

HttpDownloader does not obey the "--disable-logging" parameter

2 participants