Make bevy_reflect feature of bevy_math non-default
#16938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
added
C-Usability
alice-i-cecile
approved these changes
Dec 22, 2024
Jondolf
approved these changes
Dec 22, 2024
Jondolf
added
S-Ready-For-Final-Review
Jondolf
reviewed
Dec 22, 2024
BenjaminBrienen
approved these changes
Dec 22, 2024
auto-merge was automatically disabled
December 22, 2024 23:18
Head branch was pushed to by a user without write access
alice-i-cecile
added
the
M-Needs-Migration-Guide
pcwalton
pushed a commit
to pcwalton/bevy
that referenced
this pull request
Dec 25, 2024
) # Objective bevy_reflect is a big part of bevy_math's dependency footprint, and is often not useful when using bevy_math standalone (as I often do). The goal with this PR is to avoid pulling in those dependencies by default without compromising the usability of bevy_math types within Bevy proper. ## Solution `bevy_reflect` has been removed from default features of `bevy_math`. However, the feature is enabled by `bevy_internal`, so that `bevy_reflect` is enabled when `bevy_math` is used through `bevy`. Philosophically, if there were a feature flag toggling reflection on `bevy` globally, then whether `bevy_math` enabled `bevy_reflect` itself would depend on that, but that doesn't exist for the time being. ## Testing It compiles :) ## Migration Guide `bevy_reflect` has been made a non-default feature of `bevy_math`. (It is still enabled when `bevy_math` is used through `bevy`.) You may need to enable this feature if you are using `bevy_math` on its own and desire for the types it exports to implement `Reflect` and other reflection traits.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
bevy_reflect is a big part of bevy_math's dependency footprint, and is often not useful when using bevy_math standalone (as I often do). The goal with this PR is to avoid pulling in those dependencies by default without compromising the usability of bevy_math types within Bevy proper.
Solution
bevy_reflecthas been removed from default features ofbevy_math. However, the feature is enabled bybevy_internal, so thatbevy_reflectis enabled whenbevy_mathis used throughbevy.Philosophically, if there were a feature flag toggling reflection on
bevyglobally, then whetherbevy_mathenabledbevy_reflectitself would depend on that, but that doesn't exist for the time being.Testing
It compiles :)
Migration Guide
bevy_reflecthas been made a non-default feature ofbevy_math. (It is still enabled whenbevy_mathis used throughbevy.) You may need to enable this feature if you are usingbevy_mathon its own and desire for the types it exports to implementReflectand other reflection traits.