-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
many_components stress test improvements #16913
base: main
Are you sure you want to change the base?
Conversation
} | ||
} | ||
|
||
println!( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be info!
so it can be configured with the logging framework?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure. I see some examples use info
and some use println
. This example was using println already, so I just kept it consistent.
Needing unsafe in the benchmarks makes me feel like we could improve the API. |
it's because we're spawning things dynamically, for which I don't think we can avoid unsafe. |
Objective
Solution
insert_by_ids
instead ofinsert_by_id
. This reduces the number of archetype moves and improves startup times substantially.base_system
. I'm not sure why, but tracing spans weren't showing for this system. I think it's something to do with how pipe system works, but need to investigate more. The approach in this pr is a little better than the default span too, since it allows adding the number of entities queried to the span which is not possible with the default system span.Testing
cargo run --example many_components -F trace_tracy 1000000
and connected with tracyShowcase
Future Work