-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Remove
SetInputFocus
helper trait (#16888)
# Objective The `SetInputFocus` trait is not very useful: we're just setting a resource's value. This is a very common and simple pattern, so we should expose it directly to users rather than creating confusing indirection. ## Solution Remove the `SetInputFocus` trait and migrate existing uses to just modify the `InputFocus` resource. The helper methods on that type make this nicer than before :) P.S. This is non-breaking as bevy_input_focus has not yet shipped. ## Testing Code compiles! CI will check the existing unit tests.
- Loading branch information
1 parent
753d46f
commit df7aa44
Showing
2 changed files
with
56 additions
and
85 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters