Respect non-element node original positions when reverting on cancel #551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #550. All tests pass.
Try dragging "CCC" item below the list. Before this fix, the element gets returned to the end of the container, disregarding the fact that there were non-element nodes after it on drag start. After the fix, it gets returned to its proper position.
I tried writing a test for this issue, but I couldn't figure how to simulate actually dragging elements around, and that's required to trigger the bug. I couldn't find any tests that did dragging (AFAICT). If someone can point me to a test that actually drags elements around, I'll have a look at it and write the test.
Ideally, non-element nodes should be respected while dragging as well, but that might be a bit more difficult (just a bit, I think). I'll give that a shot if there's positive response to this PR.
Thanks!