-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BREAKING CHANGE/update kubo 0.29.0 #100
Conversation
Signed-off-by: D4ryl00 <[email protected]>
Signed-off-by: D4ryl00 <[email protected]>
Signed-off-by: D4ryl00 <[email protected]>
Signed-off-by: D4ryl00 <[email protected]>
Signed-off-by: D4ryl00 <[email protected]>
Signed-off-by: D4ryl00 <[email protected]>
Signed-off-by: D4ryl00 <[email protected]>
…arshalling Signed-off-by: D4ryl00 <[email protected]>
Signed-off-by: D4ryl00 <[email protected]>
Signed-off-by: D4ryl00 <[email protected]>
Signed-off-by: D4ryl00 <[email protected]>
Signed-off-by: D4ryl00 <[email protected]>
Signed-off-by: D4ryl00 <[email protected]>
Insecure Access Control (1)
More info on how to fix Insecure Access Control in Dockerfile. Vulnerable Libraries (19)More info on how to fix Vulnerable Libraries in Go. 👉 Go to the dashboard for detailed results. 📥 Happy? Share your feedback with us. |
Signed-off-by: D4ryl00 <[email protected]>
Signed-off-by: D4ryl00 <[email protected]>
Signed-off-by: D4ryl00 <[email protected]>
Signed-off-by: D4ryl00 <[email protected]>
Signed-off-by: D4ryl00 <[email protected]>
Signed-off-by: D4ryl00 <[email protected]>
Signed-off-by: D4ryl00 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested between two locations with Berty mini and the iOS simulator.
This PR updates
kubo
to v0.29.0 and its dependencies.Because there are many breaking changes between the previous version and this new one, many fixes were made in this PR.
The
gRPC
package deprecatedDialContext
in favor ofNewClient
, the DNS resolver should be explicitly used: https://stackoverflow.com/questions/78485578/how-to-use-the-bufconn-package-with-grpc-newclientWe removed
gogoproto
for the API generation, but copied the utility functions to read/write proto messages, into the new package protoio.The API is now generated with the official Golang protoc plugin instead of
gogoproto
.By removing
gogoproto
, we also lost some fancy features, like renaming protobuf fields, enum prefix removal or field tags. So we had to rename many fields by their standard name, likeaccountPk
instead ofaccountPK
(k is now lowercase). We added a new buf generation tool to add field tags, that is used afterprotoc-gen-go
byBuf
.The protobuf marshaling also wants
UTF-8
compatibility for string data type. Because the rendez-vous point mechanism uses protobuf string that was not UTF-8 compliant, we now use base-64 conversion because marshaling rendez-vous point address.To be able to compile the API files, we needed to update the docker image
bertytech/buf
dependencies.The Buf version was bumped and the configuration files were updated to v2.
The new
golangce-lint
version is more strict, so we fixed many unused variables, use pointers instead of objects for event transmission.